Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove ui.darkmode.enabled flag condition #1246

Merged
merged 1 commit into from
Sep 24, 2024
Merged

feat: Remove ui.darkmode.enabled flag condition #1246

merged 1 commit into from
Sep 24, 2024

Conversation

JF-Cozy
Copy link
Contributor

@JF-Cozy JF-Cozy commented Sep 23, 2024 •
edited
Loading 

### 🔧 Tech

* Remove ui.darkmode.enabled flag condition

@zatteo
Copy link
Contributor

zatteo commented Sep 23, 2024 •
edited
Loading

Looks good! Much simpler.

You just need to remove the now-unused-argument { useUserColorScheme: true } in every calls to make ts happy.

@JF-Cozy
Copy link
Contributor Author

JF-Cozy commented Sep 24, 2024

Looks good! Much simpler.

You just need to remove the now-unused-argument { useUserColorScheme: true } in every calls to make ts happy.

pff ben oui 🤦

@JF-Cozy JF-Cozy merged commit 32564a5 into master Sep 24, 2024
1 check passed
@JF-Cozy JF-Cozy deleted the feat/VER-891 branch September 24, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zatteo zatteo zatteo approved these changes

@acezard acezard Awaiting requested review from acezard acezard is a code owner

@Ldoppea Ldoppea Awaiting requested review from Ldoppea Ldoppea is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JF-Cozy @zatteo